-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] #1456
fix(deps): update module go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin to v0.44.0 [security] #1456
Conversation
…github.com/gin-gonic/gin/otelgin to v0.44.0 [security] | datasource | package | from | to | | ---------- | ---------------------------------------------------------------------------- | ------- | ------- | | go | go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin | v0.42.0 | v0.44.0 | Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: core/go.sum
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1456 +/- ##
=============================================
Coverage 50.69210% 50.69210%
=============================================
Files 356 356
Lines 24274 24274
Branches 267 267
=============================================
Hits 12305 12305
Misses 10775 10775
Partials 1194 1194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v0.42.0
->v0.44.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
GitHub Vulnerability Alerts
CVE-2023-45142
Summary
OpenTelemetry-Go Contrib has a handler wrapper
otelhttp
that adds the following labels by deafult that have unbound cardinality:http.user_agent
http.method
This leads to the server's potential memory exhaustion when many malicious requests are sent to it.
Details
HTTP header User-Agent or HTTP method for requests can be easily set by an attacker to be random and long. The library internally uses httpconv.ServerRequest that records every value for HTTP method and User-Agent.
This pull request released with version 0.44.0 dixes this vulnerability The values collected for attribute
http.request.method
were changed to be restricted to a set of well-known values and other high cardinality attributes were removed.Impact
In order to be affected program has to use otelhttp.NewHandler wrapper and does not filter any unknown HTTP methods or User agents on the level of CDN, LB, previous middleware, etc.
Others
This vulnerability is similar but different from these known vulnerabilities:
Workaround for affected versions
As a workaround, otelhttp.WithFilter() can be used instead, but it requires manual careful configuration to not log certain requests entirely.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.